Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse directly into trillium::Headers #635

Merged
merged 4 commits into from
Apr 17, 2024
Merged

feat: parse directly into trillium::Headers #635

merged 4 commits into from
Apr 17, 2024

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Apr 16, 2024

implemented as an opt-in feature, with the intent to make the feature flagged behavior default in a patch release after it's been sufficiently tested

@jbr jbr force-pushed the header-parse-0.3 branch 3 times, most recently from 8f21cbb to 751b754 Compare April 16, 2024 22:29
@jbr jbr changed the title feat(http,client): parse directly into trillium::Headers feat: parse directly into trillium::Headers Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 82.89474% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 51.47%. Comparing base (ff2a4ad) to head (cf1cd73).

Files Patch % Lines
client/src/conn.rs 68.18% 7 Missing ⚠️
http/src/conn.rs 88.63% 5 Missing ⚠️
http/src/headers.rs 88.88% 4 Missing ⚠️
http/src/received_body/chunked.rs 88.88% 3 Missing ⚠️
http/src/headers/header_name.rs 50.00% 2 Missing ⚠️
http/src/headers/header_value.rs 75.00% 1 Missing ⚠️
http/src/headers/known_header_name.rs 66.66% 1 Missing ⚠️
http/src/method.rs 75.00% 1 Missing ⚠️
http/src/status.rs 66.66% 1 Missing ⚠️
http/src/version.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x     #635      +/-   ##
==========================================
+ Coverage   49.94%   51.47%   +1.52%     
==========================================
  Files         183      183              
  Lines        6967     7190     +223     
==========================================
+ Hits         3480     3701     +221     
- Misses       3487     3489       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbr jbr merged commit 1fe9941 into 0.3.x Apr 17, 2024
7 checks passed
@jbr jbr deleted the header-parse-0.3 branch April 17, 2024 00:20
@jbr jbr restored the header-parse-0.3 branch April 17, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant